search

semigroups / Semigroups

The GAP package Semigroups
https://semigroups.github.io/Semigroups/
Other
23 stars 35 forks source link

Add FreeSemilattice constructor #995

Closed Jun2M closed 5 months ago

Jun2M commented 7 months ago

This pull request adds a new constructor for the FreeSemilattice class. The constructor takes a positive integer as input and creates a FreeSemilattice object based on the specified semigroup type. The constructor supports various semigroup types such as IsFpSemigroup, IsTransformationSemigroup, and IsPartialPermSemigroup. This addition enhances the functionality of the FreeSemilattice class and provides more flexibility in creating semilattices.

james-d-mitchell commented 5 months ago

@Jun2M I don't think the CI tests failing are anything to do the changes in your PR, there seems to be an issue with GAP at the moment:

https://github.com/gap-system/gap/issues/5672

james-d-mitchell commented 5 months ago

CI re-run after https://github.com/gap-system/gap/issues/5672 closed. Fingers crossed...

Jun2M commented 5 months ago

The check was not successful because the test for NumberOfLeftCongruences failed? I don't think I touched that code at all..?

james-d-mitchell commented 5 months ago

Probably just a spurious error, running it again :)