semiotic-ai / autoagora-agents

Apache License 2.0
1 stars 2 forks source link

Random number generation should be consistent based on the simulation configuration #23

Closed tumaysem closed 1 year ago

tumaysem commented 1 year ago

Random number generation should be consistent based on the simulation configuration.

All noise generation is based on randomness in simulation environment which can generate different output without a seed. value.

fixes #22

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3792664276


Totals Coverage Status
Change from base Build 3641331801: -0.0%
Covered Lines: 333
Relevant Lines: 559

💛 - Coveralls
tumaysem commented 1 year ago

I really wish to add the parameter to environment node in the config jSON file. But it seems there is a design decision to use the name of the node names as type of the environment to initialize. So I moved the random seed configuration to up one level.

"environment": {
  "NoisySharedSubgraph": {
      "noise": true
  }
},
"random_seed":42
tumaysem commented 1 year ago

I couldn't find any agent using pytorch randomization.