semiotic-ai / timeline-aggregation-protocol

A fast, efficient and trust-minimized unidirectional micro-payments system.
Apache License 2.0
14 stars 3 forks source link

Add integration test to ensure RAV timestamp cutoff across workspaces in the library #117

Closed ColePBryan closed 1 year ago

ColePBryan commented 1 year ago
          @severiano-sisneros could we also make sure to add a test to the integration tests to ensure this is consistent across the library? Seems like the best place to ensure the consistency.

Originally posted by @ColePBryan in https://github.com/semiotic-ai/timeline-aggregation-protocol/issues/116#issuecomment-1603425447

Desired test: Make sure that the TAP core and aggregator follow the same timestamp cutoff. The current expected is that any receipt that has a timestamp less than or equal to the most recent previous RAV should not be accepted (as apposed to simply less than). We need to create a test to make sure both the core and the aggregator each reject receipts that are equal to a previous RAV timestamp, and accept one where the receipt timestamp is just one greater than the prev rav timestamp.

ColePBryan commented 1 year ago

@severiano-sisneros can I assign this issue to you?