search

semiotic-ai / timeline-aggregation-protocol

A fast, efficient and trust-minimized unidirectional micro-payments system.
Apache License 2.0
14 stars 3 forks source link

feat(tap-core): implement serialize for receipt with state #229

Closed LNSD closed 2 months ago

LNSD commented 3 months ago

The Serialize trait is necessary to send over JSON-RPC the list of valid receipts here:

https://github.com/graphprotocol/indexer-rs/blob/7f544b283f88451b5c1173f880140134da06a392/tap-agent/src/agent/sender_allocation.rs#L521-L530

Without this, the latest changes in the main branch cannot be used in the indexer-rs repository, and as a consequence, preventing the alloy crates upgrade.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9661977211

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/receipt/state.rs 1 4 25.0%
<!-- Total: 2 5 40.0% -->
Totals Coverage Status
Change from base Build 9409648709: 0.0%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls
LNSD commented 3 months ago

Fixed the CI format check failure in 39d76b0

aasseman commented 3 months ago

The problem is somewhere else I think. We're not supposed to send ReceiptWithState to the aggregator, just the EIP712SignedMessage<Receipt>, which is already ser/de.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9667564680

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/receipt/state.rs 1 4 25.0%
<!-- Total: 2 5 40.0% -->
Totals Coverage Status
Change from base Build 9409648709: 0.0%
Covered Lines: 970
Relevant Lines: 1201
💛 - Coveralls
aasseman commented 3 months ago

This change is the problem: https://github.com/semiotic-ai/timeline-aggregation-protocol/commit/4ebf2584441514166fd9e91999b1710af1d54524#diff-ef8c3e0b9f1ddf2cd58bd9f9043483014ed6c4c978575b01d28964b3ceb3852eR14