37 update library to use ether rs keyaddress instead of using k256 library directly

[ColePBryan]

Updates library to use ethers-rs instead of k256 directly.

Changes:

• Updates K256 library items (SigningKey, VerifyingKey, etc) to ethers-rs (LocalWallet, Address, etc)
• ethers-rs library uses async for signing, so that required anything using signatures to be changed to async
• Cargo updates:
  • updated rstest to 0.17.0, improves async and causes no issues in library
  • added futures library (maintained by rust-lang), adds no audit issues
  • added aync-std an async friendly version of std-library
• Split Error enum to move receipt failure errors to a distinct enum that derives clone
• Most of the test changes are to move to ether-rs, change signature validation to recover and check, and update to async where needed

[github-actions[bot]]

Coverage after merging 37-update-library-to-use-ether-rs-keyaddress-instead-of-using-k256-library-directly into main will be

86.77%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
tap_core/src
eip_712_signed_message.rs	67.74%	100%	55.56%	72.73%	49
lib.rs	86.21%	100%	77.78%	90%	18
receipt_aggregate_voucher.rs	81.58%	100%	57.14%	87.10%	21
tap_core/src/adapters/test
collateral_adapter_mock.rs	82.98%	100%	71.43%	85%	25–26, 44, 50–52
collateral_adapter_test.rs	100%	100%	100%	100%
rav_storage_adapter_mock.rs	94.74%	100%	83.33%	96.88%	7
rav_storage_adapter_test.rs	100%	100%	100%	100%
receipt_checks_adapter_mock.rs	87.18%	100%	83.33%	87.88%	49, 53–55
receipt_checks_adapter_test.rs	95.83%	100%	100%	95%	53
receipt_storage_adapter_mock.rs	97.37%	100%	92.31%	98.41%	7
receipt_storage_adapter_test.rs	100%	100%	100%	100%
tap_core/src/tap_receipt
mod.rs	66.67%	100%	50%	75%
receipt.rs	67.65%	100%	55.56%	72%	20, 44
received_receipt.rs	82.42%	100%	75.86%	83.82%	100–102, 109–111, 113–115, 160, 171, 185–187, 95–97

[aasseman]

:thinking: not quite sure that was really needed. If a user of the lib wanted to use ethers-rs wallets, they could have used wallet.signer(), which gives you a K256 SignerKey that worked with your previous implementation.

[ColePBryan]

Thats true, but this keeps our whole library at the same level of abstraction. Previously we signed with k256, derived eip-712 with ether-rs, wrote custom code to translate to eth address from k-256. Now it is all through ethers-rs and they handle k256.

Either way the whole library was going to be updated to using recoverable signatures. This was just one approach to achieving that.

[github-actions[bot]]

Coverage after merging 37-update-library-to-use-ether-rs-keyaddress-instead-of-using-k256-library-directly into main will be

86.37%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
tap_core/src
eip_712_signed_message.rs	67.74%	100%	55.56%	72.73%	49
lib.rs	71.43%	100%	71.43%	71.43%	17
receipt_aggregate_voucher.rs	81.58%	100%	57.14%	87.10%	21
tap_core/src/adapters/test
collateral_adapter_mock.rs	82.98%	100%	71.43%	85%	25–26, 44, 50–52
collateral_adapter_test.rs	100%	100%	100%	100%
rav_storage_adapter_mock.rs	94.74%	100%	83.33%	96.88%	7
rav_storage_adapter_test.rs	100%	100%	100%	100%
receipt_checks_adapter_mock.rs	87.18%	100%	83.33%	87.88%	49, 53–55
receipt_checks_adapter_test.rs	95.83%	100%	100%	95%	53
receipt_storage_adapter_mock.rs	97.37%	100%	92.31%	98.41%	7
receipt_storage_adapter_test.rs	100%	100%	100%	100%
tap_core/src/tap_receipt
mod.rs	66.67%	100%	50%	75%
receipt.rs	67.65%	100%	55.56%	72%	20, 44
received_receipt.rs	82.42%	100%	75.86%	83.82%	100–102, 109–111, 113–115, 160, 171, 185–187, 95–97

[github-actions[bot]]

Coverage after merging 37-update-library-to-use-ether-rs-keyaddress-instead-of-using-k256-library-directly into main will be

86.37%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
tap_core/src
eip_712_signed_message.rs	67.74%	100%	55.56%	72.73%	49
lib.rs	71.43%	100%	71.43%	71.43%	17
receipt_aggregate_voucher.rs	81.58%	100%	57.14%	87.10%	21
tap_core/src/adapters/test
collateral_adapter_mock.rs	82.98%	100%	71.43%	85%	25–26, 44, 50–52
collateral_adapter_test.rs	100%	100%	100%	100%
rav_storage_adapter_mock.rs	94.74%	100%	83.33%	96.88%	7
rav_storage_adapter_test.rs	100%	100%	100%	100%
receipt_checks_adapter_mock.rs	87.18%	100%	83.33%	87.88%	49, 53–55
receipt_checks_adapter_test.rs	95.83%	100%	100%	95%	53
receipt_storage_adapter_mock.rs	97.37%	100%	92.31%	98.41%	7
receipt_storage_adapter_test.rs	100%	100%	100%	100%
tap_core/src/tap_receipt
mod.rs	66.67%	100%	50%	75%
receipt.rs	67.65%	100%	55.56%	72%	20, 44
received_receipt.rs	82.42%	100%	75.86%	83.82%	100–102, 109–111, 113–115, 160, 171, 185–187, 95–97