semiotic-ai / timeline-aggregation-protocol

A fast, efficient and trust-minimized unidirectional micro-payments system.
Apache License 2.0
14 stars 3 forks source link

refactor: RAV struct timestamp to timestamp_ns #69

Closed aasseman closed 1 year ago

aasseman commented 1 year ago

Renaming timestamp to timestamp_ns in the RAV struct.

Note: It's better not to wait too long for these kinds of changes, because naming schemes trickle all the way down to the JSON-RPC API.

github-actions[bot] commented 1 year ago

Coverage after merging rav_struct_timestamp_ns into main will be

92.08%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
tap_core/src
   eip_712_signed_message.rs64.10%100%44.44%70%41, 52
   lib.rs96.49%100%86.67%97.98%
   receipt_aggregate_voucher.rs81.58%100%57.14%87.10%21
tap_core/src/adapters/test
   collateral_adapter_mock.rs82.98%100%71.43%85%25–26, 44, 50–52
   collateral_adapter_test.rs100%100%100%100%
   rav_storage_adapter_mock.rs94.74%100%83.33%96.88%7
   rav_storage_adapter_test.rs100%100%100%100%
   receipt_checks_adapter_mock.rs87.18%100%83.33%87.88%49, 53–55
   receipt_checks_adapter_test.rs100%100%100%100%
   receipt_storage_adapter_mock.rs97.37%100%92.31%98.41%7
   receipt_storage_adapter_test.rs100%100%100%100%
tap_core/src/tap_receipt
   mod.rs75%100%57.14%82.35%
   receipt.rs67.65%100%55.56%72%20, 44
   received_receipt.rs82.42%100%75.86%83.82%100–102, 109–111, 113–115, 160, 171, 185–187, 95–97
ColePBryan commented 1 year ago

I thought they were all updated. Not sure how this one slipped by.

aasseman commented 1 year ago

Rebased onto latest main

github-actions[bot] commented 1 year ago

Coverage after merging rav_struct_timestamp_ns into main will be

86.37%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
tap_core/src
   eip_712_signed_message.rs67.74%100%55.56%72.73%49
   lib.rs71.43%100%71.43%71.43%17
   receipt_aggregate_voucher.rs81.58%100%57.14%87.10%21
tap_core/src/adapters/test
   collateral_adapter_mock.rs82.98%100%71.43%85%25–26, 44, 50–52
   collateral_adapter_test.rs100%100%100%100%
   rav_storage_adapter_mock.rs94.74%100%83.33%96.88%7
   rav_storage_adapter_test.rs100%100%100%100%
   receipt_checks_adapter_mock.rs87.18%100%83.33%87.88%49, 53–55
   receipt_checks_adapter_test.rs95.83%100%100%95%53
   receipt_storage_adapter_mock.rs97.37%100%92.31%98.41%7
   receipt_storage_adapter_test.rs100%100%100%100%
tap_core/src/tap_receipt
   mod.rs66.67%100%50%75%
   receipt.rs67.65%100%55.56%72%20, 44
   received_receipt.rs82.42%100%75.86%83.82%100–102, 109–111, 113–115, 160, 171, 185–187, 95–97