search

semiotic-ai / timeline-aggregation-protocol

A fast, efficient and trust-minimized unidirectional micro-payments system.
Apache License 2.0
14 stars 3 forks source link

Outdated Receipt and ReceiptAggregateVoucher documentation? #76

Closed severiano-sisneros closed 1 year ago

severiano-sisneros commented 1 year ago

The documentation, e.g. here and here does not match the code. Specifically it doesn't look like there is any signing happening at this level. I'm guessing that signing has been pushed to a higher level function and the documentation hasn't been updated.

ColePBryan commented 1 year ago

All signing happens in the generic Eip712SignedMessage. This struct then wraps receipt and rav. Also, with the EIP712 change the actual message being signed is different since it is signing the hash (of message + metadata) instead of the message directly.