Closed GoingMyWay closed 2 years ago
Thanks @GoingMyWay Yes, that makes sense to me. I didn't really bother much with the observation space since it doesn't appear to cause any issues when the observation space (is a superset of) contains the actual observations. I am happy to merge a PR if this fixes some use case you have in mind.
Thanks @GoingMyWay Yes, that makes sense to me. I didn't really bother much with the observation space since it doesn't appear to cause any issues when the observation space (is a superset of) contains the actual observations. I am happy to merge a PR if this fixes some use case you have in mind.
Thanks. I encountered this problem when I tried to predict x and y. The grid size is 8x8. I got x=8 and it was out of the bound.
Dear authors, after checking the code, I found that in https://github.com/semitable/lb-foraging/blob/master/lbforaging/foraging/environment.py#L125
and
For
8x8
grid, thefield_x
andfield_y
are 8. However, the positions of the grids are within the range of[0, 7]
. Ingym.spaces.Box
(https://github.com/openai/gym/blob/master/gym/spaces/box.py#L26), it is[0, 8]
. I guess it will out of range. It will not cause any error if you do not predict the obs and modify the obs.Could you please check it? If so, I will make a PR.