search

semperai / amica

Amica is an open source interface for interactive communication with 3D characters with voice synthesis and speech recognition.
https://heyamica.com
MIT License
591 stars 92 forks source link

enhancement-implemented #56

Open agrim0312 opened 7 months ago

agrim0312 commented 7 months ago

changed - Link to CustomLink in ./common.tsx due to conflict of same names

Screencast from 17-12-23 05:04:10 PM IST.webm

however, did not delete the share page file

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amica ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 0:53am
agrim0312 commented 7 months ago

fixed #52

kasumi-1 commented 7 months ago

Hi @agrim0312 thank you. However, can't merge yet as it looks like this broke the build. You can check locally by running npm run build to run the typechecker.

agrim0312 commented 7 months ago

sure

agrim0312 commented 7 months ago

@kasumi-1 fixed the build You can review it now

kasumi-1 commented 7 months ago

This freezes the character when closed. Also, there are some whitespace and indent issues - I fixed these in https://github.com/semperai/amica/tree/sharePage-2-modal-component but I am unsure of cause of freezing on close.

agrim0312 commented 6 months ago

hi @kasumi-1, I am not able to solve the issue however I have narrowed it down. As soon as VrmDemo gets loaded in the shareModal.tsx file the character freezes. I tried rendering modal without VrmDemo and it did'nt freeze and worked fine. Screenshot from 2023-12-18 17-18-11 here is the VrmDemo div. Please guide me so that I can fix the issue.

slowsynapse commented 2 months ago

I think this PR is resolved with the load/save VRM feature added. Will double check in future.