semplon / summernote-ext-elfinder

Summernote Plugin for elFinder File Manager
MIT License
24 stars 21 forks source link

CHANGE: Added caller argument to elfinderDialog() #4

Closed ChristopherMeyering closed 7 years ago

ChristopherMeyering commented 7 years ago

With this patch the elfinderDialog() method gets the calling DOM element as argument.

This is helpfull if you use multiple elfinder and summernote instances on the same page.

semplon commented 7 years ago

is this work well @ChristopherMeyering ?

ChristopherMeyering commented 7 years ago

@semplon I deployed this patch to multiple applications we created and which are productive. It worked quite fine.

If the elfinderDialog() doesn't use it everything is fine, too. Because this only adds an argument.

semplon commented 7 years ago

Ok @ChristopherMeyering i'll try it first to check. nice patch. i hope this can fix my problem with multiple summernote on one page with elFinder