Fix #106 (rework MySQL based Store implementation)

k00ni commented 6 years ago

Background information as well as my motivation is described in #106. I would like to keep the issue for non-technical discussions.

Until now, i focused on the following points of my agenda:

[x] Make Store code readable, means, PSR 2 compliant
[x] implement a way to get code coverage of all the Store related code (using phpdbg + PHPUnit)
- i also integrated it into coveralls.io: current report
[x] write tests to cover "major" parts of the Store code (~80-90%) - incomplete, will be fixed in the future
- [x] written tests for major queries, such as DELETE, INSERT INTO, ...
- [x] pushed test coverage of ARC2_Store class to 63%; i ignored all functions which i didnt understand yet or which seemed not "needed".

After these tests are written, we can focus on porting the code to PDO.

EDIT: My mistake, this pull was not intended to get merged right away. :D But its OK, i've adapted the list and will create another pull.

semsol commented 6 years ago

Awesome stuff, @k00ni :-) Thank you for all the hard work to make the code less embarrassing ;-)

I have added you to the list of repo collaborators, so you should have push access now. And feel free to add your @author annotations to the code.

I should have a bit more time in 2019, so will hopefully contribute more again then.

Benji

k00ni commented 6 years ago

I have added you to the list of repo collaborators, so you should have push access now. And feel free to add your @author annotations to the code.

Thank you, its an honor :)

semsol / arc2