search

semsol / arc2

ARC RDF Classes for PHP
Other
331 stars 92 forks source link

Potential fix for #122 and #114 #123

Closed cbinding closed 5 years ago

cbinding commented 5 years ago

Condition logic amended

k00ni commented 5 years ago

Thank you

Ref:

I am currently very busy, but try to get back to you as soon as possible.

k00ni commented 5 years ago

Hi @cbinding, your fix seems to break some tests. We currently have 2 tests which always fail in travis, but with this PR further ones fail. Could you check this please? Nervermind my comment. I found out, that these tests were failing before your PR already.

I am currently very busy and not have the time to merge/fix this situation. What i would suggest is, i leave this PR open for now. But further PRs will not be merged until these tests are fixed.

Maybe someone could help us out here?

Anyway, thanks for your effort @cbinding!