Huge (with big H) cleanup of the code base to prepare it for long term support. In the following a summary of all major changes:
:exclamation: Default table engine changed from MyISAM to InnoDB
Fixed a lot of deprecation warnings in PHP 8.2 (mostly dynamic property usage and deprecated utf8_* usage)
Removed the following DB adapters: mysqli, PDO-sqlite:
mysqli adapter was kept for compatibility reasons, has known problems with MySQL 8.0.
PDO SQLite was removed because it was buggy and it didn't pass our tests.
also removed CachedAdapter
Removed methods:
ARC2_Class::queryDB(...), because it relied on outdated mysqli usage.
AbstractAdapter + PDOAdapter: getServerInfo(); changed getServerVersion() to use SQL select version() to get DB server version
Cleaned require- and require-dev section in composer.json. For instance, removed symfony/cache.
Upgraded Dockerfile to use PHP 8.2
Field db_con in ARC2 configuration was removed. It used to hold the mysqli connection.
Deployed PHP-CS-Fixer to the whole code base to improve readability.
Updated our Github workflows to use newer DB versions (such as MariaDB 10.5+)
Salvaged a fix from @craigdietrich: fixes #133 and fixes #135
CC @semsol @bnowack What do you think? The library is barely used and didn't receive any updates since 2021. Because it is a dependency of my EasyRdf fork (https://github.com/sweetrdf/easyrdf), I want it to remain stable and somewhat working on newer PHP versions.
Merging this pull request will result in version 3 to be released :exclamation:
Huge (with big H) cleanup of the code base to prepare it for long term support. In the following a summary of all major changes:
ARC2_Class::queryDB(...)
, because it relied on outdated mysqli usage.getServerInfo()
; changedgetServerVersion()
to use SQLselect version()
to get DB server versioncomposer.json
. For instance, removedsymfony/cache
.db_con
in ARC2 configuration was removed. It used to hold the mysqli connection.CC @semsol @bnowack What do you think? The library is barely used and didn't receive any updates since 2021. Because it is a dependency of my EasyRdf fork (https://github.com/sweetrdf/easyrdf), I want it to remain stable and somewhat working on newer PHP versions.
Merging this pull request will result in version 3 to be released :exclamation: