search

semsol / arc2

ARC RDF Classes for PHP
Other
332 stars 89 forks source link

Fix : PDO::exec returns a false equivalent #157

Closed dev-quentin closed 2 months ago

dev-quentin commented 2 months ago

Hello,

Correction of an incorrect comparison in ARC2_StoreSelectQueryHandler.php: https://github.com/semsol/arc2/blob/3e08bc2af723496967bcdedff663e8094f6e5e66/store/ARC2_StoreSelectQueryHandler.php#L183

The PDO::exec function returns false on error, so === should be used instead of ==.

Solve issue: https://github.com/semsol/arc2/issues/156#issue-2448671739

k00ni commented 2 months ago

Thank you @dev-quentin. I am busy currently and don't know when I can have a look into that, but I will try. Ignore the failing coding style check, I probably fix them in a separate PR.

dev-quentin commented 2 months ago

Thank you, @k00ni. This is my first pull request 😀. If you correct the coding style in another pull request, should I close this request, or will you do it?

k00ni commented 2 months ago

If you correct the coding style in another pull request, should I close this request, or will you do it?

I will fix the coding styles in a separate pull request and merge it into master afterwards. This PR stays open, you don't have to do anything about the coding style issues. This way we don't pollute your fix and keep things clear.

k00ni commented 2 months ago

Thank you @dev-quentin