update NMEA GGA sent to the ntrip caster with number of satellite, RTK fix status, and age of differential

[yydgis]

pygnssutils Pull Request Template

Description

The current ntrip client sends a NMEA GGA with a fake number of satellite (15), always SPP for GNSS solution type, and always 0 for age of differential, instead of the real-time GNSS solution status from the receiver.

Fixes # (issue)

Testing

Pass the test for test_gnssdump.py.

Checklist:

• [X] I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
• [X] My code follows the style guidelines of this project (see CONTRIBUTING.md).
• [X] I have performed a self-review of my own code.
• [ ] (if appropriate) I have cited my u-blox documentation source(s).
• [ ] I have commented my code, particularly in hard-to-understand areas.
• [ ] I have made corresponding changes to the documentation.
• [ ] (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
• [X ] I have tested my code against the full tests/test_*.py unittest suite.
• [X] My changes generate no new warnings.
• [ ] Any dependent changes have been merged and published in downstream modules.
• [X] I have signed my commits.
• [X] I understand and acknowledge that the code will be published under a BSD 3-Clause license.

[semuadmin]

Hi @yydgis,

Thanks for the contribution. I appreciate the intention here, but unfortunately changing the footprint of the get_coordinates() function has knock-on effects in other external applications which are not addressed here, including PyGPSClient.

I'm also not sure the additional GGA information would actually be used by any mainstream NTRIP Caster - to the best of my knowledge, NTRIP Casters which request GGA information are principally interested in the client lat/lon for geofencing purposes - the numSV and DGPS correction parameters would be redundant (if you know otherwise, I'll happily stand corrected on this).

I'll keep the PR open while I assess the wider implications. I'm happy to make the corresponding changes in PyGPSClient but would obviously need to ensure the PRs are synchronised.

Thanks

[semuadmin]

Hi @yydgis

Appreciate the contribution, but I've decided instead to implement this functionality in RC 1.0.32 in a way that minimises the impact on PyGPSClient.

Some context here...

Many of the utilities in pygnssutils were originally developed as core functionality in PyGPSClient, but were separated out into discrete CLI utilities for the benefit of those users who didn't want or need a GUI application. But there are still strong inter-dependencies between PyGPSClient and pygnssutils, so I need to be mindful that changes to either are appropriately coordinated.

Thanks again.