semuconsulting / pyspartn

Python library for parsing SPARTN protocol messages.
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

update OCB decoding #12

Closed semuadmin closed 1 year ago

semuadmin commented 1 year ago

pyspartn Pull Request Template

RELEASE CANDIDATE 0.2.0-alpha

  1. OCB payload definitions and decoding updated.
  2. pyspartn can now successfully decode all GAD and HPAC payloads and the majority of OCB payloads (though further testing is required to validate decoded payload content), but some small OCB payloads (nData < 35 bytes) cannot yet be successfully decoded. For the time being, a temporary override has been implemented in spartnmessage.py to suppress the decode flag for those payload types that cannot yet be successfully decoded. This will be removed once testing is completed.

Fixes Failed OCB payload decodes

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist: