semuconsulting / pyubx2

Python library for parsing and generating UBX GPS/GNSS protocol messages.
BSD 3-Clause "New" or "Revised" License
175 stars 68 forks source link

Fix issue #122 #123

Closed dcrowe closed 1 year ago

dcrowe commented 1 year ago

pyubx2 Pull Request Template

Description

Fixes #122

Testing

Tests have been run, but there don't appear to be any tests covering this change. Would you like a regression test added?

Checklist:

semuadmin commented 1 year ago

@dcrowe

Thanks for the contribution - much appreciated. I've merged your PR into RC 1.2.30. There is already a test of MON-RF parsing in test_stream.py (testMONLOG) but unfortunately it contains a jammingState value of 0 so didn't show up the issue.

I note also that the attribute currently defined as jamInd is referred to as cwSuppression in later versions, but I'll retain the existing name to minimise regression impact.

If you happen to have a real raw binary datastream containing a UBX MON-RF with a jammingState > 1, I'd be grateful if you could send me it and I'll add it to the test scripts - otherwise I can synthesize one. Thanks.