semuconsulting / pyubx2

Python library for parsing and generating UBX GPS/GNSS protocol messages.
BSD 3-Clause "New" or "Revised" License
173 stars 67 forks source link

Asyncio streamer example #40

Closed Hadatko closed 2 years ago

Hadatko commented 3 years ago

Signed-off-by: Cervenka Dusan cervenka@acrios.com

pyubx2 Pull Request Template

Description

Based on #34 adding asyncio streamer example.

Testing

currently not tested

Checklist:

semuadmin commented 3 years ago

Hello again!

You do realise you're not getting paid for these, right ;-)?

It may be a little while before I get around to reviewing this (among other things, I need to get my head around the pySerial-asynchio library), but in the meantime could I ask you to provide a clearer rationale for the approach you've used?

  1. What are you looking to achieve here in practical terms? What problem does this solve? What use case(s) would it be applicable to?
  2. How does this improve on the existing UBXStreamer example, from an end-user perspective?
  3. What empirical metrics do you have to back this up e.g. benchmarks, system resource logs, etc.?
  4. How do you propose to test it?

Cheers!

Hadatko commented 2 years ago

Hi, sorry i was not responding. I was focused on work.

  1. I think this has same usecase as original example
  2. cpu usage for current example is 100% when we are not writting/reading data to/from device. New example is solving that.
  3. We have script to measure docker container resources. Current solution is fine in terms of resource consumtion.
  4. Well i think test may look similar to original streamer.