API v2.2 is not compatible with v2.1

semuxproject / semux-core

Semux Core

https://www.semux.org

MIT License

76 stars 31 forks source link

API v2.2 is not compatible with v2.1 #145

Closed semuxgo closed 5 years ago

semuxgo commented 5 years ago

Some of the endpoints have been updated to include VM results. Not sure if these changes will affect clients, especially exchanges.

orogvany commented 5 years ago

Hm. We can filter transactions not matching types. Are you suggesting we also clear new fields like block.gasused?

witoldsz commented 5 years ago

Introducing VM could be a good opportunity to bump API to v3… That could also allow for a change to make a more clear distinction which endpoints are tied to node's wallet/private keys and which are not (useful for open API gateways like https://api.semux.online or https://sempy.online/api/ui/ and, in general, to Semux API integrators).

semuxgo commented 5 years ago

After some investigation, I think we should probably keep the existing endpoints untouched. I'd also propose to add new endpoints to support VM functionalities:

/transaction/call for CALL transactions
/transaction/create for CREATE transactions
/receipt for retrieving transaction receipts

These changes are non-intrusive, so we can either continue with 2.2 or jump to 3.0

orogvany commented 5 years ago

I think those endpoints exist already... Except receipt

We may want to move call local into it's own call so API gateways can more easily support local calls

orogvany commented 5 years ago

Think this can be closed