Re-enable HD wallet - Githubissues

semuxproject / semux-core

Semux Core

https://www.semux.org

MIT License

76 stars 31 forks source link

Re-enable HD wallet #231

Closed semuxgo closed 5 years ago

semuxgo commented 5 years ago

Credit to @orogvany

Set the hd passphrase to empty
Use fixed schme: SLIP10, English, Mainnet
Optimize UI/UX
Encrypt the mnemonic phrase and account index

semuxgo commented 5 years ago

I'd like to go with SLIP-10 for now, as it's well tested and supported by trezor? The wallet stores the raw mnemonic phrase. We can derive keys based on any scheme of user choice in the future, for instance BIP32-ED25519 for Ledger support.

orogvany commented 5 years ago

I thought slip-10 was not the one trezor used. Thought they used the cardano one?

orogvany commented 5 years ago

Oh. Slip-10 is trez and cardano is ledger?

orogvany commented 5 years ago

So depends on which one we want to Target. Trez accepts pull requests, ledger is closed source? Or maybe I have backwards

semuxgo commented 5 years ago

@orogvany Here is the reference to Trezor, https://github.com/trezor/trezor-firmware/tree/master/core/docs/coins. Would appreciate it if you can double check.