semuxproject / semux-core

Semux Core
https://www.semux.org
MIT License
76 stars 31 forks source link

Register bip44 number #50

Closed orogvany closed 5 years ago

orogvany commented 6 years ago

https://github.com/satoshilabs/slips/blob/master/slip-0044.md

For bip44 support we need to assign a number for semux.

Anyone care which num we register?

borderline23 commented 6 years ago

semux in binary

01110011 01100101 01101101 01110101 01111000

mdodong commented 6 years ago

90817 Date semux first post on bct.

semuxgo commented 6 years ago

How about using our genesis hash?

orogvany commented 6 years ago

It's a max value of 2^31 they state it in hex and decimal must start with 1 bit for hardened

some thoughts 0xDEADBEEF (classic funny in hex) 0x80005344 (sem in hex 1337.. kinda.) (decimal: 21316) 0x800008AE (decimal: 2222 nice memorable number) 0x8dec0ded (decimal: 99356141)

borderline23 commented 6 years ago

sem in hex

gpip commented 6 years ago

btw, it's a requirement that there's a wallet using this before it's added to slip-0044.

0x8073656d (sem with 0x80 prefix)

orogvany commented 6 years ago

@gpip Yes, I saw the requirement that there's a wallet using this. Thanks for the reminder.

I have a lib that uses this currently and supports BIP44. Currently it only supports regular addresses, but we are extending to use Ed25519. I'm not sure if their requirement is for full wallet integration or if a library counts, but wanted to be ready :D

orogvany commented 5 years ago

Last call for suggested code? Going with @gpip s suggestion if i do not hear back. thanks

mdodong commented 5 years ago

+1 with @gpip 's suggestion

orogvany commented 5 years ago

filed https://github.com/satoshilabs/slips/pull/454

orogvany commented 5 years ago

Number accepted/registered