senaite / senaite.core

Enterprise Open Source Laboratory System (LIMS)
https://senaite.com
GNU General Public License v2.0
254 stars 145 forks source link

More informative progress of the sample analyses states #2485

Closed ramonski closed 8 months ago

ramonski commented 8 months ago

Description of the issue/feature this PR addresses

This PR improves the "Number of Analyses" column info in the sample listing:

Current behavior before PR

Only verified and total number was displayed

Desired behavior after PR is merged

Number of analyses are displayed as: Open / To be verified / Verified / Total

An info is displayed when moving the mouse over the number and the same color codes as the WF states are used.

I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.

ramonski commented 8 months ago

I would rather stick to the distinct numbers instead of a bar with a variable width to have it more intuitive for the user. In the progress bar approach (although I like the design), it would be also difficult to display if e.g. 10/10 verified, but not published. Is the published bar then invisible? Does it show half/half? Do the other bars disappear? Therefore, I guess we should keep it as simple as possible.

ramonski commented 8 months ago

I guess a usable solution could be to use the progress bar styling and apply 25% per part. Would you prefer this styling?

xispa commented 8 months ago

I guess a usable solution could be to use the progress bar styling and apply 25% per part. Would you prefer this styling?

I like it more than simply the numbers, yes. At least it becomes more "easy" to get the point on a quick look

ramonski commented 8 months ago

Ok, then I'll change it to this styling.

ramonski commented 8 months ago

I changed it now to the progress bar style and chose the same width as our current %-progress:

The mousover help text is still possible

ramonski commented 8 months ago

I tested the brown "sample received" background for the first number, but it looked a bit sh***y