senaite / senaite.core

Enterprise Open Source Laboratory System (LIMS)
https://senaite.com
GNU General Public License v2.0
254 stars 145 forks source link

Retract/Retest action kills HIDDEN mark of the analysis while recreates #2529

Closed toropok closed 6 months ago

toropok commented 6 months ago

Description

In one of our setups, we declare auxiliary tests as HIDDEN. However, when these tests are retracted or retested and new instances are created as replacements, they are not marked as HIDDEN. This can be confusing for lab staff because they have to double-check it. Otherwise, if they miss it, these auxiliary tests may end up being published.

I think that happens here: place where Hidden mark skipped

It can be fixed here in create_analisys or in upper layer in create_retest method.

Was this behavior intentional, or should I create a pull request to fix it?