search

senaite / senaite.core

Enterprise Open Source Laboratory System (LIMS)
https://senaite.com
GNU General Public License v2.0
254 stars 145 forks source link

Migrate SubGroups to DX #2545

Closed toropok closed 5 months ago

toropok commented 5 months ago

Description of the issue/feature this PR addresses

This PR migrates the AT based Sub Groups (SubGroup) to Dexterity

Current behavior before PR

Sub Groups are based on the Archetype Framework

Desired behavior after PR is merged

Sub Groups are based on the Dexterity Framework

-- I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.

toropok commented 5 months ago

@xispa ready for review

toropok commented 5 months ago

Hi @toropok, works well, many thanks! Can you just resolve the conflicts, then this one can be merged next.

@ramonski

hi :) done. Ready to go for next one

toropok commented 5 months ago

@ramonski

I'm very sorry for that, but I found my typo in this PR. What is right way to fix it?

it is located here: https://github.com/senaite/senaite.core/blob/976c3f8fbacbb12d72d2d7ed2920329526767b61/src/senaite/core/profiles/default/types/SubGroup.xml#L14

need just replace factory ContainerType->SubGroup

can we just correct it (hope nobody get it yet) or need to issue patch with remigration?

P.S.: I dont know how I missed this typo due we test everything locally first.

ramonski commented 5 months ago

Hi @toropok, no worries, I didn't catch that error either during review. Just make a new PR that corrects this issue and put a proper description that it corrects this issue from #2545. There is no need for a separate changelog line. Thanks for your work and efforts, much appreciated!