search

senaite / senaite.core

Enterprise Open Source Laboratory System (LIMS)
https://senaite.com
GNU General Public License v2.0
254 stars 145 forks source link

Fix SubGroups migration typo #2557

Closed toropok closed 5 months ago

toropok commented 5 months ago

Fix default factory typo from #2545

Description of the issue/feature this PR addresses

typo

Current behavior before PR

Desired behavior after PR is merged

fix

-- I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.

toropok commented 5 months ago

Thanks for the quick fixture! However, you need to re-import the typestool so that these changes take effect. Therefore, you new a new upgrade step and metadata version

@ramonski

sorry, I've got it wrong. Is that right now?

ramonski commented 5 months ago

Ah, now I get what went wrong. The migrated objects were created already as ContainerType types:

Ok, that's indeed kind of bad, but I guess it should be ok since we fixed it so quick.

toropok commented 5 months ago

Ok, that's indeed kind of bad, but I guess it should be ok since we fixed it so quick.

that's absolutely my fault, I will do my best to not let it happen again.. thanks for your assistance and support