Move Instrument Locations to Senaite setup folder

senaite / senaite.core

Enterprise Open Source Laboratory System (LIMS)

https://senaite.com

GNU General Public License v2.0

254 stars 145 forks source link

Closed Bugerman58 closed 4 months ago

Bugerman58 commented 4 months ago

Move InstrumentLocation and InstrumentLocations to Senaite setup folder, cleanup and refactoring

Now it lives in bika_setup folder

Now it lives in setup folder

-- I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.

Bugerman58 commented 4 months ago

@xispa Hi, this PR ready for review. pls, check it.

ramonski commented 4 months ago

Hi @Bugerman58, Thanks for keeping this one in sync with the latest PR merges in 2.x! This one will be next, promise!

Bugerman58 commented 4 months ago

Hi @Bugerman58, Thanks for keeping this one in sync with the latest PR merges in 2.x! This one will be next, promise!

Hi, @ramonski Thanks! =)

ramonski commented 4 months ago

Hi @Bugerman58, The migrated instrument location has duplicate Title/Description fields:

Probably, you need to remove the plone.app.dexterity.behaviors.metadata.IBasic behavior from the InstrumentLocation.xml...

ramonski commented 4 months ago

Yes, removing it manually also removes the default Title/Description coming in from the behavior: