search

senaite / senaite.core

Enterprise Open Source Laboratory System (LIMS)
https://senaite.com
GNU General Public License v2.0
254 stars 145 forks source link

Remove unnecessary stuff and fallback to [] in getRaw #2597

Closed xispa closed 3 months ago

xispa commented 3 months ago

Description of the issue/feature this PR addresses

This is a complementary PR of #2593

-- I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.

toropok commented 3 months ago

@xispa there is triple #2593 in CHANGE.RST lines duplicated

2.6.0 (unreleased)
------------------

- #2593 Always do a full reindex of the object after transition
- #2593 Retrieve and store object's raw data on snapshot creation
- #2593 Skip permissions update after transition when InternalUse is unchanged
xispa commented 3 months ago

@xispa there is triple #2593 in CHANGE.RST lines duplicated

Thanks for the heads-up @toropok . Yes, this PR was done while running a profiler to check the time the system takes to run each function from the execution stack. Several things came out of this, that were splited accross the following PRs:

From all the above, there are three things that are handled in this PR.

I rephrased now one of the entries from the changelog that related to this PR, but was later partially "moved to" https://github.com/senaite/senaite.app.supermodel/pull/23 . See https://github.com/senaite/senaite.core/pull/2597/commits/ef6f547636bb04386ca913bb187c6a0cca1e0114

toropok commented 3 months ago

@xispa thanks! I was thinking just numbering issue :) sorry