senaite / senaite.core

Enterprise Open Source Laboratory System (LIMS)
https://senaite.com
GNU General Public License v2.0
254 stars 145 forks source link

Fix "Other reasons" for rejection are not saved on sample registration #2610

Closed xispa closed 2 months ago

xispa commented 2 months ago

Description of the issue/feature this PR addresses

This Pull Request fixes that the sample is not automatically rejected when using "Other reasons" only without selecting predefined reasons in sample add form:

Captura de 2024-08-22 17-20-46

The sample is created and transitioned as usual (to sample_due or received) instead.

Current behavior before PR

Sample is not automatically rejected when using "Other reasons" only in sample add form

Desired behavior after PR is merged

Sample is automatically rejected when using "Other reasons" only in sample add form

-- I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.

xispa commented 2 months ago

Actually, the problem was that "Other reasons" were not saved. Will update the title of the Pull Request and the changelog accordingly