Completely remove 'Editable' Analysis Specifications

[lemoene]

Am editing for clarity at https://github.com/senaite/senaite.core/issues/601, and am breaking this one out. Needed a the link already for reference there

I was under the impression 'Editable Analysis Specifications' were removed during the AR Create form refactoring for performance improvements already. Only sponsors DBW (many Specs) probably ever used it properly, some research labs showed interest, and it can be removed for simplicity's sake and decluttering too

Steps to reproduce, Current behavior

The so-called AR's own Specs is still available as a set-up option

Also as Client preference

And on the AR Create form, the Specs are still editable too

Expected behavior

'Analysis Request Specifications' as Specs option should be removed

The Spec fields should not be editable on the AR Create, in fact can be removed?

[ramonski]

AR Specs can be since the change to AR Add (and before) be deactivated with this setup setting:

Hence, there is no need to remove them in code.

The option "Default AR Specifications" is completely useless as stated already in https://github.com/senaite/senaite.core/issues/601 and will be therefore removed.

[lemoene]

phew, apologies I completely did not see that option...

re #601 "Default AR Specifications" is completely useless, you mean the 'Editable AR Specifications' i think, tagged Enable AR Specifications in you screenshot

Default 'AR Specifications' eg per Sample Type (lab) is critical. But can be dropped from AR Create in this round, and applied automatically to all New ARs if Analysis Specifications are on in the Setup, I just noticed there isn't such an option. Low priority

[lemoene]

And to clear the mud further, they should be called Analysis Specifications, they are applied to Analysis results.

Note translation bug on Client

is correct in the Setup

shall I copy pasta this to a separate issue?