search

senar-ai / web

Website Senar.ai
https://senar.ai
87 stars 2 forks source link

Rethinking pro version of fortawesome #2

Closed mazipan closed 2 years ago

mazipan commented 2 years ago

We can not use the pro version since it needs a token to download the icon.

It blocks the other contributors to run the code locally.

Or is there any way to share the token to other contributors? Not sure about the legality and the security just by sharing the token.

zainfathoni commented 2 years ago

I'll try to find a way to make it easier to contribute. Extracting the SVG files is one of the possible alternatives.

zainfathoni commented 2 years ago

I removed the dependencies to the Font Awesome Pro license in this commit https://github.com/senar-ai/web/commit/6c2baa6514b47ff2aee0e87ec6851841ce65d73f while slightly improving the bundle size in the process. 😁

Smaller JS bundles without Font Awesome dependencies

Now any contributors should be able to run this project without needing a license! 🎉