search

sencha / ext-react

Sencha ExtReact
https://www.sencha.com/products/extreact
Other
91 stars 39 forks source link

Proposed change: accept `sass` and `resources` configs for Webpack-generated app.json #91

Open scotthovestadt opened 5 years ago

scotthovestadt commented 5 years ago

Hello,

My use-case is transitioning a very large ExtJS over to ExtReact. Obviously, the entire app cannot be transitioned over immediately, but I'm working on setting it up so that React will bootstrap the app and reference the base components. The idea is to slowly migrate, bottom up, to ExtReact.

To achieve this use-case, I need to be able to pass sass and resources parameters to app.json. The change was easy-- I just modified createAppJson in artifacts.js to write the configs and index.js to pass them.

I'm happy to submit a PR with my change. Any chance we could get it pushed to NPM?

mgusmano commented 5 years ago

if you could submit the pr we will look at it - thanks

you need to fill out this CLA first

https://github.com/sencha/ext-react/blob/master/Sencha-CLA.pdf

scotthovestadt commented 5 years ago

Any particular email where I can send the CLA?

branflake2267 commented 5 years ago

brandon.donnelson@sencha.com or info@sencha.com

scotthovestadt commented 5 years ago

@branflake2267 thanks! expect it shortly