sencha / package-loader

Ext JS Dynamic Package Loader
36 stars 16 forks source link

How is loadScripts supposed to work with loadOrder and files #2

Open no1melman opened 7 years ago

no1melman commented 7 years ago

The below snippet outlines the loadScripts function.

https://github.com/sencha/package-loader/blob/49c0699ab325066dc950df293482f4707a745349/packages/package-loader/src/package/Entry.js#L60-L78

When it runs through the files, it will look them up in the loadOrder and then append them to a paths array:

https://github.com/sencha/package-loader/blob/49c0699ab325066dc950df293482f4707a745349/packages/package-loader/src/package/Entry.js#L70-L73

However, it appears that the load function doesn't handle urls being an array, yet clearly the loadScripts is expecting at some point to pass it one.

https://github.com/sencha/package-loader/blob/49c0699ab325066dc950df293482f4707a745349/packages/package-loader/src/package/Entry.js#L80-L102

So, I've manipulated this so that I have extended the manifest loadOrder with my own, and I have files on the metadata. But obviously when it goes to load the urls, it fails....