search

send2vinnie / mclinker

Automatically exported from code.google.com/p/mclinker
Other
0 stars 0 forks source link

code review request #138

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:

Purpose of code changes on this branch:
Enable partial linking for Hexagon backend.

When reviewing my code changes, please focus on:
/include/mcld/LD/Relocator.h

After the review, I'll merge this branch into:
master

Original issue reported on code.google.com by khem...@codeaurora.org on 11 Apr 2013 at 9:48

GoogleCodeExporter commented 9 years ago 
Hi, Diana,

Can you review this branch?

Best regards,
Luba

Original comment by LubaTang on 12 Apr 2013 at 2:16

GoogleCodeExporter commented 9 years ago 
The change on /include/mcld/LD/Relocator.h is fine for me. However, please 
notice that when doing partial linking, the pass 'applyRelocations' will be 
skipped, so the updated addend may not be added back to relocation offset. Of 
course, if relocations of Hexagon are all "Rela" type and you'd like to keep 
the offset information in "r_addend" but "r_offset", then no need to concern 
about this problem.  

Other comments please refer to 
https://code.google.com/p/mclinker/source/detail?r=ba144c4504e9eabed6e894634c98a
75250324188

Original comment by mysekki on 12 Apr 2013 at 3:45

GoogleCodeExporter commented 9 years ago 
Sorry for the typo, when using Relocation::updateAddend to update the offset 
when doing partial linking, I mean 'the offset information keeps in "r_addend" 
but relocation target place', not "r_offset".

Original comment by mysekki on 12 Apr 2013 at 4:17

GoogleCodeExporter commented 9 years ago

Original comment by pete.c...@gmail.com on 18 Sep 2013 at 11:27