Bump Sendgrid http client library to use latest apache http client 5

sendgrid / java-http-client

SendGrid's Java HTTP Client for calling APIs

https://sendgrid.com

MIT License

25 stars 78 forks source link

Bump Sendgrid http client library to use latest apache http client 5 #147

Open ahrooran-r opened 4 months ago

ahrooran-r commented 4 months ago

This latest version of sendgrid does not support apache http client 5. I saw another issue where you are trying to use JDK specific http libraries. However, its been in stale since 2016 and last comment during 2022 also has no useful updates.

Could you please bump the library to use Http Client 5 at least? https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5

jkosternl commented 3 months ago

Yes, for our project https://github.com/frankframework/frankframework we are using SendGrid as well, which uses this java-http-client which depends on the old org.apache.httpcomponents:httpclient:4.*.

ryantomlinson95 commented 1 week ago

I raised a PR to bump the library to use httpclient5, since we use SendGrid in our project that we're upgrading to httpclient5.

jkosternl commented 1 week ago

Great job @ryantomlinson95 👍🏻
I hope the maintainers can proceed with your changes and merge it and release a new version.