sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

125 stars 101 forks source link

Conformance to style standards #100

Closed movanelli closed 5 years ago

movanelli commented 5 years ago

Fixes #94

Checklist

[X] I have made a material change to the repo (functionality, testing, spelling, grammar)
[X] I have read the [Contribution Guide] and my PR follows them.
[X] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

made changes in files as suggested by pycodestyle following PEP8 code compliance

├── python_http_client
│   └── client.py
└── tests
└── test_daterange.py

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

SendGridDX commented 5 years ago

All committers have signed the CLA.

misterdorm commented 5 years ago

Please rebase and address conflicts. Thanks!

hugovk commented 5 years ago

How about moving pycodestyle from the after_script: section to the script: section?

That way any issues found will fail the build, meaning they will have to be fixed and won't sneak into the codebase.

codecov[bot] commented 5 years ago

Codecov Report

Merging #100 into master will not change coverage. The diff coverage is 50%.

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files           6        6           
  Lines         293      293           
=======================================
  Hits          268      268           
  Misses         25       25

Impacted Files	Coverage Δ
python_http_client/client.py	`77.66% <50%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a45c299...75d053e. Read the comment docs.

movanelli commented 5 years ago

Just fixed both situations @misterdorm and @hugovk . I appreciate your suggestions.

I just have a question about "50% of diff hit (target 91.46%)" on code checks. It's about the coverage of my code? I haven't changed any logic on code, it's necessary to me to develop unit tests about the lines I changed? Any help would be appreciated :slightly_smiling_face:

thinkingserious commented 5 years ago

Hello @moshemeirelles,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX