sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

126 stars 101 forks source link

add missed Python 3.7 classifier #105

Closed StrikerRUS closed 6 years ago

StrikerRUS commented 6 years ago

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[n/a] I have added tests that prove my fix is effective or that my feature works
[n/a] I have added necessary documentation about the functionality in the appropriate .md file
[n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

add missed Python 3.7 classifier. Refer to #91.

codecov[bot] commented 6 years ago

Codecov Report

Merging #105 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files           6        6           
  Lines         289      289           
=======================================
  Hits          264      264           
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9196b9f...74f9488. Read the comment docs.

hugovk commented 6 years ago

Tip: put a comma after the 3.7 classifier.

That way, when the 3.8 classifier is added (with its own comma), the diff is smaller and shows one new line, instead of one change and one addition.

StrikerRUS commented 6 years ago

Thank you, @hugovk ! Done.

thinkingserious commented 6 years ago

Hello @StrikerRUS,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious commented 6 years ago

Hello @StrikerRUS,

Thanks again for the PR!

You have earned 20 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid