sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs
https://sendgrid.com
MIT License
126 stars 101 forks source link

String Formatting and PEP-8 fixes #111

Closed vkmrishad closed 6 years ago

vkmrishad commented 6 years ago

Checklist

Short description of what this PR does:

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

codecov[bot] commented 6 years ago

Codecov Report

Merging #111 into master will decrease coverage by 24.22%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #111       +/-   ##
===========================================
- Coverage   91.34%   67.12%   -24.23%     
===========================================
  Files           6        6               
  Lines         289      289               
===========================================
- Hits          264      194       -70     
- Misses         25       95       +70
Impacted Files Coverage Δ
tests/test_unit.py 69.59% <ø> (-29.61%) :arrow_down:
tests/test_repofiles.py 100% <ø> (ø) :arrow_up:
python_http_client/client.py 54.36% <50%> (-23.31%) :arrow_down:
python_http_client/exceptions.py 73.68% <0%> (-23.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9196b9f...5ef47d3. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

Merging #111 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files           6        6           
  Lines         293      293           
=======================================
  Hits          268      268           
  Misses         25       25
Impacted Files Coverage Δ
tests/test_unit.py 99.2% <ø> (ø) :arrow_up:
tests/test_repofiles.py 100% <ø> (ø) :arrow_up:
python_http_client/client.py 77.66% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a45c299...ed8b8e2. Read the comment docs.

vkmrishad commented 6 years ago

@misterdorm

vkmrishad commented 6 years ago

@misterdorm Please add available labels and merge this PR

thinkingserious commented 6 years ago

Hello @vkmrishad,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

vkmrishad commented 6 years ago

@thinkingserious @misterdorm Thank you