search

sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs
https://sendgrid.com
MIT License
125 stars 101 forks source link

feat: add API logging to client #123

Closed tysonholub closed 4 years ago

tysonholub commented 5 years ago

This PR adds logging to the client API calls and additionally the API request method to the client Response

SendGridDX commented 5 years ago

CLA assistant check
All committers have signed the CLA.

tysonholub commented 5 years ago

Will this PR be merged?

thinkingserious commented 5 years ago

Hello @tysonholub,

I'm not sure just yet, it's still in our backlog for a code review. My apologies for the delay and thank you for your patience.

With Best Regards,

Elmer

codecov[bot] commented 4 years ago

Codecov Report

Merging #123 into main will decrease coverage by 0.28%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   92.73%   92.45%   -0.29%     
==========================================
  Files           6        6              
  Lines         303      305       +2     
==========================================
+ Hits          281      282       +1     
- Misses         22       23       +1
Impacted Files Coverage Δ
python_http_client/client.py 81.37% <80.00%> (-0.08%) :arrow_down:
python_http_client/exceptions.py 97.36% <0.00%> (-0.07%) :arrow_down:
tests/test_unit.py 99.26% <0.00%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aef38bc...14c67c3. Read the comment docs.

childish-sambino commented 4 years ago

Fixes https://github.com/sendgrid/python-http-client/issues/141