search

sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs
https://sendgrid.com
MIT License
126 stars 101 forks source link

setup.py includes tests directory in package data #131

Closed bwind closed 4 years ago

bwind commented 5 years ago

Issue Summary

setup.py includes all packages (containing an init.py) using find_packages(). This is a problem because it will include the tests directory as a top level importable module in the local app, breaking our own tests that happen to live in a directory with the same name.

Steps to Reproduce

  1. pip install python-http-client
  2. ls /usr/local/lib/python3.7/site-packages/ and observe tests is there as a top level importable package
  3. import tests from local app will import python-http-client's tests, not the app's tests

Either init.py should be excluded from the package data, or (rather) the entire tests directory.

Technical details: