Closed georgeyk closed 6 years ago
Looking at https://travis-ci.org/sendgrid/python-http-client/jobs/281829725 it is not related with the changes in PR (or at least, not obviously related - something in distutils :cry: ).
We are removing support for v2.6, so no worries :)
Any feedback here ? I was looking to the tests, but I'm not sure if this change is entirely testable in the current structure.
Hi @georgeyk,
My apologies, this issue is still on my backlog for review. I hope to review it soon.
With Best Regards,
Elmer
Hello @georgeyk,
This PR finally came up on my backlog :)
I tried to fix the conflicts, but GitHub is not happy :( Do you mind fixing them? Otherwise, this PR looks good to go.
With Best Regards,
Elmer
Hi @thinkingserious,
I'm sorry about the late response, but I finally managed to update the PR.
Thanks @georgeyk!
Hello @georgeyk,
Thanks again for the PR!
We appreciate your contribution and look forward to continued collaboration. Thanks!
Team SendGrid DX
A work-in-progress fix for https://github.com/sendgrid/python-http-client/issues/20
We can use
timeout
in the client scope, so it will apply the given timeout value for all requests and/or by specific request call (the requesttimeout
will take precedence over the clienttimeout
configuration`).I need to improve the tests, but I'll wait for the initial feedback.