search

sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs
https://sendgrid.com
MIT License
125 stars 101 forks source link

Timeout added for opener #42

Closed prabhakar267 closed 6 years ago

prabhakar267 commented 6 years ago

Fixes #20

SendGridDX commented 6 years ago

CLA assistant check
All committers have signed the CLA.

thinkingserious commented 6 years ago

Thank you @prabhakar267!

Please add this parameter to the calling functions so that it can be configurable.

With Best Regards,

Elmer

prabhakar267 commented 6 years ago

@thinkingserious I have updated the parameter and all calling functions Also, I had to update a unit test. :smile:

thinkingserious commented 6 years ago

@prabhakar267

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

thinkingserious commented 6 years ago

https://github.com/sendgrid/python-http-client/pull/21#issuecomment-391087056