sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs
https://sendgrid.com
MIT License
125 stars 101 forks source link

Add a PEP8 check to travis.yml #63

Closed mbernier closed 6 years ago

mbernier commented 6 years ago

Issue Summary

According to codeClimate, this repo is not conforming with PEP8 standards. Please add a PEP8 check to Travis that will cause the build to fail if the proper rules are not being met.

Steps to Reproduce

  1. Install the check
  2. Make obvious PEP8 standards violation in one of the files
  3. Make a PR
  4. Let the build run
  5. See a failure in the build
  6. Fix the issue and make a comment (so we know)
  7. Get a free Hacktoberfest shirt (so long as your first PR is in Oct)
NdagiStanley commented 6 years ago

@mbernier The last step is being fixed by #64 , right? Regardless, I have fixed the issue and we have successful builds now.

NdagiStanley commented 6 years ago

Secondly, from the travis build we see: image

I have updated it from pep8 to pycodestyle.