Closed jlindenger closed 6 years ago
I'm not sure what I did that caused some of the older commits to show up here since they were already in master. Any idea?
Did you try to squash your commits ?
@jlindenger
We can’t merge your PR without the CLA being signed.
[ ] Sign the CLA before November 3rd [ ] Tag @mbernier and @thinkingserious to let us know it is signed
Then we will comment with a link to get your shirt!
@mbernier @thinkingserious CLA should be good now. Apparently I had one commit that snuck in with my work email, so I needed to fix that. The conflict is probably something that you should resolve right before you merge (just taking out the unused imports in test_unit.py). I think the underlying file is too much of a moving target to keep pulling in and fixing before a merge.
Awesome, thanks @jlindenger! If you have not already, you can redeem your swag here. Thanks!
Merging #65 into master will decrease coverage by
0.05%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 92.22% 92.17% -0.06%
==========================================
Files 6 6
Lines 296 294 -2
==========================================
- Hits 273 271 -2
Misses 23 23
Impacted Files | Coverage Δ | |
---|---|---|
tests/test_unit.py | 99.21% <100%> (-0.02%) |
:arrow_down: |
python_http_client/__init__.py | 100% <100%> (ø) |
:arrow_up: |
python_http_client/client.py | 79.2% <66.66%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 70797c3...6aced08. Read the comment docs.
Hello @jlindenger,
Thanks again for the PR!
We appreciate your contribution and look forward to continued collaboration. Thanks!
Team SendGrid DX
Fixes #64
Description of the change: I knocked out some quick fixes for your PEP8 issues. There's actually a few more in there than the ones you linked from CodeClimate as well because I just ran flake8 locally using your tox.ini file.
Reason for the change: Conforming to standards for #64