search

sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs
https://sendgrid.com
MIT License
125 stars 101 forks source link

Update travis.yml to fail on Pep8 errors #66

Closed NdagiStanley closed 6 years ago

NdagiStanley commented 6 years ago

Description of the change: Update travis.yml to fail on Pep8 errors

Reason for the change: Fixes #63

mbernier commented 6 years ago

@NdagiStanley

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

NdagiStanley commented 6 years ago

I have filled out the form. Could you tell me why the PR couldn't be merged? I still want to finish this :)

thinkingserious commented 6 years ago

Hi @NdagiStanley,

Your PR has not been merged simply because we are way behind :( There were over 1,000 PRs submitted to us in October and we are currently merging them from oldest to newest while also trying to make sure you all get your swag.

We appreciate your contribution and patience.

With Best Regards,

Elmer

mbernier commented 6 years ago

I merged the conflicts and we're now waiting for Travis to build -

in the meantime ...

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer @sendgrid-ci

thinkingserious commented 6 years ago

Hello @NdagiStanley,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX