Use triple double-quoted strings for docstring (PEP8), fix typo

sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

125 stars 101 forks source link

Use triple double-quoted strings for docstring (PEP8), fix typo #71

Closed delirious-lettuce closed 6 years ago

delirious-lettuce commented 6 years ago

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

Use triple double-quoted strings for docstring (PEP8)
Fix typos:
- erro -> error
- successsful -> successful

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

SendGridDX commented 6 years ago

All committers have signed the CLA.

thinkingserious commented 6 years ago

@delirious-lettuce

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

mbernier commented 6 years ago

@delirious-lettuce

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer @SendGrid

thinkingserious commented 6 years ago

Hi @delirious-lettuce,

This has come up to the top of my backlog to merge. Could you please fix the merge conflict so that I may merge this PR?

Thanks!

With Best Regards,

Elmer

delirious-lettuce commented 6 years ago

@thinkingserious ,

I actually deleted my fork a while ago since I thought this PR was abandoned. I could fork and re-submit a new PR that does the exact same thing but otherwise I'm not sure how to proceed?

thinkingserious commented 6 years ago

A new PR would work, thanks!

delirious-lettuce commented 6 years ago

@thinkingserious ,

Ok, sorry about the mixup! I'll re-submit ASAP.

thinkingserious commented 6 years ago

No worries @delirious-lettuce :)

We are running very behind due to a wonderful Hacktoberfest turn out.

delirious-lettuce commented 6 years ago

@thinkingserious ,

No problem at all, I can only imagine how hard it would be to go through hundreds (if not thousands!) of pull requests!