sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

125 stars 101 forks source link

Fix #80 #82

Closed delirious-lettuce closed 6 years ago

delirious-lettuce commented 6 years ago

Fixes

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

Fix #80 (remove a blank line above test definition, fix line length)

While I was fixing the above issue, I also cleaned up a couple other things in the file.

Remove unused imports
Remove excess whitespace
Add whitespace around = operator

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

thinkingserious commented 6 years ago

Thanks @delirious-lettuce! I've added this to our backlog for review.

thinkingserious commented 6 years ago

Hello @delirious-lettuce,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

delirious-lettuce commented 6 years ago

@thinkingserious ,

No problem!

codecov[bot] commented 6 years ago

Codecov Report

Merging #82 into master will decrease coverage by 0.05%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   92.28%   92.22%   -0.06%     
==========================================
  Files           6        6              
  Lines         298      296       -2     
==========================================
- Hits          275      273       -2     
  Misses         23       23

Impacted Files	Coverage Δ
tests/test_unit.py	`99.21% <100%> (-0.02%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecb28e5...4ae4d97. Read the comment docs.