sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

126 stars 101 forks source link

Fix travis build errors #83

Closed delirious-lettuce closed 6 years ago

delirious-lettuce commented 6 years ago

Fixes

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

Changing the copyright year in LICENSE.txt from 2017 -> 2018 fixes one of the two current Travis build errors.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

codecov[bot] commented 6 years ago

Codecov Report

Merging #83 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files           6        6           
  Lines         296      296           
=======================================
  Hits          273      273           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 969b515...cdb00f6. Read the comment docs.

delirious-lettuce commented 6 years ago

I just went and found an example USE_CASES.md from another SendGrid repo and created a stub for this repo.

https://github.com/sendgrid/sendgrid-php/blob/master/USE_CASES.md

Creating this file and updating the year fixes both travis build errors. I'm not sure if simply creating this file fixes #78 but it's a start!

thinkingserious commented 6 years ago

Awesome, thanks @delirious-lettuce!

thinkingserious commented 6 years ago

Hello @delirious-lettuce,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX