Closed RohitK89 closed 6 years ago
Thanks @RohitK89,
This is now on our backlog for review and merge.
Hello @RohitK89,
Thanks again for taking the time to make a PR.
Why do you think we need a Manifest.in file? According to this thread, it seems like it's not needed.
With Best Regards,
Elmer
I added sendgrid as a package on conda-forge ( https://anaconda.org/conda-forge/sendgrid), and the lack of a manifest meant that I had to explicitly specify the license. It's not necessary strictly, but it makes it easier for the package to be maintained elsewhere.
On Tue, May 22, 2018 at 5:22 PM, Elmer Thomas notifications@github.com wrote:
Hello @RohitK89 https://github.com/RohitK89,
Thanks again for taking the time to make a PR.
Why do you think we need a Manifest.in file? According to this thread https://stackoverflow.com/questions/24727709/do-python-projects-need-a-manifest-in-and-what-should-be-in-it, it seems like it's not needed.
With Best Regards,
Elmer
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sendgrid/python-http-client/pull/87#issuecomment-391145208, or mute the thread https://github.com/notifications/unsubscribe-auth/AHuKQHoUZ7S92WuNBPGelO0QwdBDcyqkks5t1IGegaJpZM4UE7Fa .
Sounds good, thanks!
Hello @RohitK89,
Thanks again for the PR!
We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!
Team SendGrid DX
Fixes
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.