sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

126 stars 101 forks source link

Client refactor #88

Closed 0bsearch closed 5 years ago

0bsearch commented 6 years ago

Fixes

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

Better signatures for client; minor refactoring

SendGridDX commented 6 years ago

All committers have signed the CLA.

codecov[bot] commented 6 years ago

Codecov Report

Merging #88 into master will increase coverage by 1.72%. The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   91.46%   93.19%   +1.72%     
==========================================
  Files           6        6              
  Lines         293      294       +1     
==========================================
+ Hits          268      274       +6     
+ Misses         25       20       -5

Impacted Files	Coverage Δ
tests/test_unit.py	`99.26% <100%> (+0.06%)`	:arrow_up:
python_http_client/client.py	`80.64% <50%> (+2.97%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa72b74...8812835. Read the comment docs.

thinkingserious commented 6 years ago

Thank you @3lnc! I've added this to our backlog for a code review.

misterdorm commented 6 years ago

@3lnc Please address conflicts and code coverage failures. Thanks!

thinkingserious commented 6 years ago

Hi @3lnc,

When you get a moment to make the updates I'd love to merge this before we release v4 of the sendgrid-python library which will depend on this library.

Thanks!

With Best Regards,

Elmer

thinkingserious commented 5 years ago

Hello @3lnc,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX