sendgrid / python-http-client

Twilio SendGrid's Python HTTP Client for calling APIs

https://sendgrid.com

MIT License

125 stars 101 forks source link

Drop support for EOL Python #90

Closed hugovk closed 5 years ago

hugovk commented 6 years ago

Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation about the functionality in the appropriate .md file
[n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

Drop support for EOL Pyhon

Python 2.6 and 3.2-3.3 are EOL and no longer receiving security updates (or any updates) from the core Python team.

Version	Release date	Supported until
2.6	2008-10-01	2013-10-29
3.0	2008-12-03	2009-06-27
3.1	2009-06-27	2012-04-09
3.2	2011-02-20	2016-02-27
3.3	2012-09-29	2017-09-29

They're also little used.

This PR drops support for them, removes old compatibility code, upgrades some code to make use of newer Python features, and fixes some typos.

SendGridDX commented 6 years ago

All committers have signed the CLA.

codecov[bot] commented 6 years ago

Codecov Report

Merging #90 into master will decrease coverage by 0.26%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   91.61%   91.34%   -0.27%     
==========================================
  Files           6        6              
  Lines         298      289       -9     
==========================================
- Hits          273      264       -9     
  Misses         25       25

Impacted Files	Coverage Δ
python_http_client/client.py	`77.66% <100%> (ø)`	:arrow_up:
tests/test_unit.py	`99.2% <100%> (-0.02%)`	:arrow_down:
tests/test_repofiles.py	`100% <100%> (ø)`	:arrow_up:
tests/test_daterange.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2a3ba0...41d56fe. Read the comment docs.

thinkingserious commented 5 years ago

Hello @hugovk,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX